Uploaded image for project: 'Drivers'
  1. Drivers
  2. DRIVERS-2189

getMore helper should explicitly send inherited comment

XMLWordPrintableJSON

    • Needed
    • Hide

      This ticket changes how getMore command should treat the comment. Drivers should sync unified spec tests find, aggregate, and changeStreams from mongodb/specifications@0fc77cd.

      Show
      This ticket changes how getMore command should treat the comment . Drivers should sync unified spec tests find, aggregate, and changeStreams from mongodb/specifications@0fc77cd .
    • $i18n.getText("admin.common.words.hide")
      Key Status/Resolution FixVersion
      CXX-2450 Fixed 3.7.0
      CSHARP-4046 Done 2.15.0
      GODRIVER-2303 Duplicate
      JAVA-4489 Duplicate
      NODE-3984 Duplicate
      MOTOR-890 Duplicate
      PYTHON-3119 Fixed 4.1
      RUBY-2902 Fixed 2.18.0
      RUST-1179 Duplicate
      SWIFT-1485 Duplicate
      PHPLIB-749 Fixed 1.13.0-beta1, 1.13.0
      CDRIVER-4199 Fixed 1.22.0, 1.22.0-beta0
      $i18n.getText("admin.common.words.show")
      #scriptField, #scriptField *{ border: 1px solid black; } #scriptField{ border-collapse: collapse; } #scriptField td { text-align: center; /* Center-align text in table cells */ } #scriptField td.key { text-align: left; /* Left-align text in the Key column */ } #scriptField a { text-decoration: none; /* Remove underlines from links */ border: none; /* Remove border from links */ } /* Add green background color to cells with FixVersion */ #scriptField td.hasFixVersion { background-color: #00FF00; /* Green color code */ } /* Center-align the first row headers */ #scriptField th { text-align: center; } Key Status/Resolution FixVersion CXX-2450 Fixed 3.7.0 CSHARP-4046 Done 2.15.0 GODRIVER-2303 Duplicate JAVA-4489 Duplicate NODE-3984 Duplicate MOTOR-890 Duplicate PYTHON-3119 Fixed 4.1 RUBY-2902 Fixed 2.18.0 RUST-1179 Duplicate SWIFT-1485 Duplicate PHPLIB-749 Fixed 1.13.0-beta1, 1.13.0 CDRIVER-4199 Fixed 1.22.0, 1.22.0-beta0

      Summary

      When a cursor was created with comment option set, subsequent getMore command called for this cursor should explicitly send same comment, so that the comment is visible in monitoring events for getMore.

      If getMore command is send without a comment, it still inherits the comment from the command that created the cursor. The comment will be visible in profiler, logs and $currentOp for that command. However, the comment will not be visible in monitoring events emitted for getMore. Since the main purpose of the comment is to help with debugging/monitoring/detecting problems, it should be visible in monitoring events.

      Therefore, when a driver send a getMore command on a cursor that was created with a comment, the driver must send the same comment as an option of getMore command. 

      See https://mongodb.slack.com/archives/C0VD105QA/p1643632893344749 for an example.

      Motivation

      Who is the affected end user?

      Any user that wants to use comment for tracing purposes, and who relies on command monitoring for this task.

      Is this issue urgent?

      No. It might be easier to implement this together with DRIVERS-742, but this is not required.

      Is this ticket only for tests?

      No.

            Assignee:
            dmitry.rybakov@mongodb.com Dmitry Rybakov
            Reporter:
            dmitry.rybakov@mongodb.com Dmitry Rybakov
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: