Uploaded image for project: 'Drivers'
  1. Drivers
  2. DRIVERS-2290

No error raised for bulkWrite with comment on <= 3.2

    • Type: Icon: Spec Change Spec Change
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Component/s: CRUD
    • Labels:
    • Needed
    • Hide

      Drivers should sync unified crud spec tests to mongodb/specifications@b8371ea.

      Show
      Drivers should sync unified crud spec tests to mongodb/specifications@b8371ea .
    • $i18n.getText("admin.common.words.hide")
      Key Status/Resolution FixVersion
      CXX-2498 Fixed 3.7.0
      CSHARP-4151 Won't Do
      GODRIVER-2394 Duplicate
      JAVA-4591 Fixed 4.7.0
      NODE-4207 Works as Designed
      MOTOR-947 Duplicate
      PYTHON-3238 Won't Do
      RUBY-2970 Won't Do
      RUST-1291 Duplicate
      SWIFT-1554 Duplicate
      CDRIVER-4199 Fixed 1.22.0, 1.22.0-beta0
      PHPLIB-749 Fixed 1.13.0-beta1, 1.13.0
      $i18n.getText("admin.common.words.show")
      #scriptField, #scriptField *{ border: 1px solid black; } #scriptField{ border-collapse: collapse; } #scriptField td { text-align: center; /* Center-align text in table cells */ } #scriptField td.key { text-align: left; /* Left-align text in the Key column */ } #scriptField a { text-decoration: none; /* Remove underlines from links */ border: none; /* Remove border from links */ } /* Add green background color to cells with FixVersion */ #scriptField td.hasFixVersion { background-color: #00FF00; /* Green color code */ } /* Center-align the first row headers */ #scriptField th { text-align: center; } Key Status/Resolution FixVersion CXX-2498 Fixed 3.7.0 CSHARP-4151 Won't Do GODRIVER-2394 Duplicate JAVA-4591 Fixed 4.7.0 NODE-4207 Works as Designed MOTOR-947 Duplicate PYTHON-3238 Won't Do RUBY-2970 Won't Do RUST-1291 Duplicate SWIFT-1554 Duplicate CDRIVER-4199 Fixed 1.22.0, 1.22.0-beta0 PHPLIB-749 Fixed 1.13.0-beta1, 1.13.0

      No Error on RunCommand comment for (version <= 3.2)

      BulkWrite doesn't appear to error on versions <= 3.2 if a comment is included in the run command:

      > db.runCommand({ delete: "records", deletes: [], comment: "x" })
      { "ok" : 1, "n" : 0 }
      

      However, version=3.6 does result in an error:

      Enterprise test> db.runCommand({ delete: "records", deletes: [], comment: "x" })
      MongoServerError: BSON field 'delete.comment' is an unknown field.
      

       

      Original Description

      The DBX-GO team is running into two errors when trying to implement GODRIVER-2199, which was split from DRIVER-742 .

      No error on Aggregation (3.6 <= version <= 4.2)

      The aggregate.json spec test expects an error when using the comment query modifier on a (3.6 <= version <= 4.2) match aggregate stage. However, testing this on a 3.6.23 server does not return an error:

      Enterprise test> db.runCommand({ aggregate: "records", pipeline: [], comment: "x", cursor: {}})
      {
        cursor: { firstBatch: [], id: Long("0"), ns: 'test.records' },
        ok: 1
      }

      It may be worth noting that the 3.6 documentation includes support for aggregation comments.

      No Error on RunCommand comment for (version <= 3.2)

      Similar to the above issue, BulkWrite doesn't appear to error on versions <= 3.2 if a comment is included in the run command:

      > db.runCommand({ delete: "records", deletes: [], comment: "x" })
      { "ok" : 1, "n" : 0 }
      

      However, version=3.6 does result in an error:

      Enterprise test> db.runCommand({ delete: "records", deletes: [], comment: "x" })
      MongoServerError: BSON field 'delete.comment' is an unknown field.
      

            Assignee:
            preston.vasquez@mongodb.com Preston Vasquez
            Reporter:
            preston.vasquez@mongodb.com Preston Vasquez
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: