Uploaded image for project: 'Drivers'
  1. Drivers
  2. DRIVERS-2466

Test invalid spec tests in check_schema_version.sh

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Minor - P4 Minor - P4
    • None
    • Component/s: Unified Test Runner
    • None
    • Not Needed

      Summary

      In this PR comment from DRIVERS-2385, I noticed that the schema version in the unified test format's Makefile was outdated. The original purpose of that Makefile was the validate unified tests across all specs using the latest schema version and also test the spec's "invalid" tests, which should fail validation.

      DRIVERS-1767 introduced a CI workflow to validate spec tests against their exact "schemaVersion", but notably omits the "invalid" tests. I propose that we remove this Makefile and update check_schema_version.sh to test "invalid" spec tests.

      Additionally, we can look into optimizing the CI script to execute ajv once per distinct schema file. It currently invokes ajv once per test file, which is much slower than the older Makefile.

      Motivation

      Who is the affected end user?

      Spec editors.

      How does this affect the end user?

      Schema files may not be fully tested.

      Is this issue urgent?

      No.

      Is this ticket required by a downstream team?

      No.

      Is this ticket only for tests?

      Yes.

            Assignee:
            Unassigned Unassigned
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: