Uploaded image for project: 'Drivers'
  1. Drivers
  2. DRIVERS-2609

Deprecate sharded-replicaset topology type and clean up redundant runOnRequirements

    XMLWordPrintableJSON

Details

    • Needed
    • Hide

      Sync spec tests to mongodb/specifications@474ddfc for the following directories:

      • change-streams/tests/unified
      • client-side-operations-timeout/tests
      • retryable-writes/tests/unified
      • sessions/tests
      • transactions/tests/unified
      • unified-test-format/tests/valid-pass
      • versioned-api/tests

      No test runner changes should be required.

      Show
      Sync spec tests to mongodb/specifications@474ddfc for the following directories: change-streams/tests/unified client-side-operations-timeout/tests retryable-writes/tests/unified sessions/tests transactions/tests/unified unified-test-format/tests/valid-pass versioned-api/tests No test runner changes should be required.

    Description

      Summary

      I came across some redundant runOnRequirement definitions in various spec tests while reviewing mongodb/specifications#1389 for DRIVERS-2577. For instance, some specs include both "sharded-replicaset" and "sharded" in the same topologies array.

      MongoDB 3.6+ requires that all shards be replica sets (see: Shard Replica Sets from the MongoDB 3.6 release notes). With that in mind, the "sharded-replicaset" topology is not useful for runOnRequirements that specify a minServerVersion of 3.6+.

      Historically, I cannot recall a case where a test incorrectly used "sharded" instead of "sharded-replicaset". This would only have been an issue for testing on pre-3.6 servers, but most of the features that require replica sets already require 3.6+ (e.g. change streams, transactions). Additionally, the mongo-orchestration configs in drivers-evergreen-tools have historically used replica sets for shards.

      The Unified Test Format spec format would do well to deprecate "sharded-replicaset" and encourage tests to use "sharded" in its place (when targeting 3.6+ servers).

      Motivation

      Who is the affected end user?

      Driver developers.

      How does this affect the end user?

      Using "sharded-replicaset" adds unnecessary overhead. Additionally, redundant runOnRequirements make tests files more verbose.

      Is this issue urgent?

      No.

      Is this ticket required by a downstream team?

      No.

      Is this ticket only for tests?

      Yes.

      Attachments

        Issue Links

          related to

          Task - A task that needs to be done. DRIVERS-2610 Note that load-balanced topologies are backed by sharded clusters with replica sets

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. DRIVERS-2675 Remove use of "sharded-replicaset" in runCommand spec tests

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. PHPLIB-1202 Assume sharded clusters use replica sets in test suite

          • Trivial - P5 - Cosmetic problem like misspelt words or misaligned text.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. PHPLIB-464 isShardedClusterUsingReplicasets() should check all shards

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          split to

          Task - A task that needs to be done. CDRIVER-4639 Deprecate sharded-replicaset topology type and clean up redundant runOnRequirements

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Backlog

          Task - A task that needs to be done. CSHARP-4649 Deprecate sharded-replicaset topology type and clean up redundant runOnRequirements

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Backlog

          Task - A task that needs to be done. GODRIVER-2838 Deprecate sharded-replicaset topology type and clean up redundant runOnRequirements

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Backlog

          Task - A task that needs to be done. PYTHON-3712 Deprecate sharded-replicaset topology type and clean up redundant runOnRequirements

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Backlog

          Task - A task that needs to be done. CXX-2690 Deprecate sharded-replicaset topology type and clean up redundant runOnRequirements

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. JAVA-4961 Deprecate sharded-replicaset topology type and clean up redundant runOnRequirements

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. MOTOR-1132 Deprecate sharded-replicaset topology type and clean up redundant runOnRequirements

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. PHPLIB-1132 Sync unified spec tests for revised runOnRequirements

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. RUBY-3254 Deprecate sharded-replicaset topology type and clean up redundant runOnRequirements

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. RUST-1649 Deprecate sharded-replicaset topology type and clean up redundant runOnRequirements

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. NODE-5276 Deprecate sharded-replicaset topology type and clean up redundant runOnRequirements

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Scheduled

          Activity

            People

              jmikola@mongodb.com Jeremy Mikola
              jmikola@mongodb.com Jeremy Mikola
              Andreas Braun Andreas Braun
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: