Uploaded image for project: 'Drivers'
  1. Drivers
  2. DRIVERS-2976

Remove deprecated field from GridFS unified tests

XMLWordPrintableJSON

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Unknown Unknown
    • None
    • Component/s: GridFS
    • Needed
    • Hide

      Spec tests for the GridFS spec have been updated to no longer include the deprecated md5, contentType, and aliases fields. The tests in question don't assert driver behaviour but only include values in the initial documents, which are then re-used in outcome assertions.

      Additionally, a test verifying that a contentType provided during an upload operation is correctly stored in the document. If your driver still supports this deprecated field, you will want to keep this particular test around until the behaviour is removed.

      To update, sync the gridfs spec tests to commit 12be2dfab99bdad54c3499174b0519ddb4588332.

      Show
      Spec tests for the GridFS spec have been updated to no longer include the deprecated md5 , contentType , and aliases fields. The tests in question don't assert driver behaviour but only include values in the initial documents, which are then re-used in outcome assertions. Additionally, a test verifying that a contentType provided during an upload operation is correctly stored in the document. If your driver still supports this deprecated field, you will want to keep this particular test around until the behaviour is removed. To update, sync the gridfs spec tests to commit 12be2dfab99bdad54c3499174b0519ddb4588332 .
    • $i18n.getText("admin.common.words.hide")
      Key Status/Resolution FixVersion
      CDRIVER-5818 Backlog
      CXX-3191 Backlog
      CSHARP-5423 In Code Review
      GODRIVER-3441 Backlog
      JAVA-5709 Fixed 5.3.0
      NODE-6581 Backlog
      MOTOR-1416 Duplicate
      PYTHON-4990 Backlog
      PHPLIB-1595 Fixed 1.20.0
      RUBY-3597 Backlog
      RUST-2107 Backlog
      PHPLIB-1218 Fixed 2.0.0
      $i18n.getText("admin.common.words.show")
      #scriptField, #scriptField *{ border: 1px solid black; } #scriptField{ border-collapse: collapse; } #scriptField td { text-align: center; /* Center-align text in table cells */ } #scriptField td.key { text-align: left; /* Left-align text in the Key column */ } #scriptField a { text-decoration: none; /* Remove underlines from links */ border: none; /* Remove border from links */ } /* Add green background color to cells with FixVersion */ #scriptField td.hasFixVersion { background-color: #00FF00; /* Green color code */ } /* Center-align the first row headers */ #scriptField th { text-align: center; } Key Status/Resolution FixVersion CDRIVER-5818 Backlog CXX-3191 Backlog CSHARP-5423 In Code Review GODRIVER-3441 Backlog JAVA-5709 Fixed 5.3.0 NODE-6581 Backlog MOTOR-1416 Duplicate PYTHON-4990 Backlog PHPLIB-1595 Fixed 1.20.0 RUBY-3597 Backlog RUST-2107 Backlog PHPLIB-1218 Fixed 2.0.0

      Summary

      The unified spec test "upload when contentType is provided" tests a field that is deprecated and that need to be removed (see DRIVERS-2656). This test need to be removed or replaced by a test adding the content type as a "metadata".

      Additionally, all the fixtures data contain the fields "md5", "contentType" and "aliases". This fields are removed from the implementation, they need to be removed from the data.

      Motivation

      Who is the affected end user?

      Developers of GridFS implementations

      How does this affect the end user?

      We don't test the download and delete features on files identical to those we create.

      How likely is it that this problem or use case will occur?

      Blocking DRIVERS-2656, unless the test is skipped.

      If the problem does occur, what are the consequences and how severe are they?

      -

      Is this issue urgent?

      no

      Is this ticket required by a downstream team?

      Yes

      Is this ticket only for tests?

      Unified tests only

      Acceptance Criteria

      The unified tests must be compatible with a GridFS implementation without the fields md5, contentType and aliases.

            Assignee:
            jerome.tamarelle@mongodb.com Jérôme Tamarelle
            Reporter:
            jerome.tamarelle@mongodb.com Jérôme Tamarelle
            Andreas Braun Andreas Braun
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: