Add period-separated dbref tests

ExportXMLWordPrintableJSON

    • Type: Spec Change
    • Resolution: Unresolved
    • Priority: Unknown
    • None
    • Component/s: BSON & Extended JSON
    • None
    • Needed
    • Hide

      Summary of necessary driver changes

      • sync updated source/bson-corpus/tests/dbref.json
        • three new valid cases exercise `$ref` containing periods
      • NO driver code changes expected unless your driver goes against the spec and modifies it
        • Note: C and Rust have already validated green, Node has a real bug and will be fixing it (NODE-7790)

      Commits for syncing spec/prose tests
      (and/or refer to an existing language POC if needed)

      Context for other referenced/linked tickets

      •  NODE-7790 - js-bson bug that motivated this addition
      Show
      Summary of necessary driver changes sync updated source/bson-corpus/tests/dbref.json three new valid cases exercise `$ref` containing periods NO driver code changes expected unless your driver goes against the spec and modifies it Note: C and Rust have already validated green, Node has a real bug and will be fixing it ( NODE-7790 ) Commits for syncing spec/prose tests (and/or refer to an existing language POC if needed)   f5ba7f7aaa0417e35671a3ed7a8cd26be3a8e5ba Context for other referenced/linked tickets   NODE-7790 - js-bson bug that motivated this addition
    • $i18n.getText("admin.common.words.hide")
      Key Status/Resolution FixVersion
      CDRIVER-6478 Fixed 2.6.0
      CXX-3589 Works as Designed
      CSHARP-6239 Done 4.0.0
      GODRIVER-4161 Fix Not Needed
      JAVA-6320 Investigating
      NODE-7866 Backlog
      PYTHON-6121 Fixed 4.19.0
      PHPLIB-1955 Done
      RUBY-3965 Backlog
      RUST-2507 Ready for Work
      $i18n.getText("admin.common.words.show")
      #scriptField, #scriptField *{ border: 1px solid black; } #scriptField{ border-collapse: collapse; } #scriptField td { text-align: center; /* Center-align text in table cells */ } #scriptField td.key { text-align: left; /* Left-align text in the Key column */ } #scriptField a { text-decoration: none; /* Remove underlines from links */ border: none; /* Remove border from links */ } /* Add green background color to cells with FixVersion */ #scriptField td.hasFixVersion { background-color: #00FF00; /* Green color code */ } #scriptField td.willNotDo { background-color: #FF0000; /* Red color code */ } /* Center-align the first row headers */ #scriptField th { text-align: center; } Key Status/Resolution FixVersion CDRIVER-6478 Fixed 2.6.0 CXX-3589 Works as Designed CSHARP-6239 Done 4.0.0 GODRIVER-4161 Fix Not Needed JAVA-6320 Investigating NODE-7866 Backlog PYTHON-6121 Fixed 4.19.0 PHPLIB-1955 Done RUBY-3965 Backlog RUST-2507 Ready for Work

      Summary

      Current bson dbref spec tests do not have a dot-separated collection name.

      Motivation

      Who is the affected end user?

      Client libraries that may be modifying collection name against spec, like Node Driver and https://jira.mongodb.org/browse/NODE-7790

      How does this affect the end user?

      End users get the spec-defined dbref behavior. For Node Driver users, this will lead to correct behavior regarding dots in the collection name.

      How likely is it that this problem or use case will occur?

      Edge case. BSON dbref is an old standard, the Node Driver has been doing its buggy thing forever, and we were just notified about this. Very unlikely that any other drivers are impacted.

      If the problem does occur, what are the consequences and how severe are they?

      Different behavior of Node Driver and any other impacted drivers, but the new behavior is technically correct, while the old behavior was always wrong.

      Is this issue urgent?

      No.

      Is this ticket required by a downstream team?

      Needed by Node Driver team, we had a bug in the driver that would have been exposed if these tests existed.

      Is this ticket only for tests?

      Just a test improvement.

      Acceptance Criteria

      There are dot-separated collection names in dbref spec tests.

            Assignee:
            Pavel Safronov
            Reporter:
            Pavel Safronov
            Pavel Safronov Pavel Safronov
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: