ExportXMLWordPrintableJSON

    • Type: Task
    • Resolution: Done
    • Priority: Major - P3
    • None
    • Component/s: Evergreen Tools
    • None
    • Not Needed

      Summary

      Lint checks (pre-commit, eslint) run on pull requests, but no status checks are required to merge. Dependabot PR #904 merged on 29 Oct 2026 with its own eslint job already failing. The bump to @eslint/js 10 enabled the no-useless-assignment rule, which now fails on two pre-existing scripts, so master has been red since and every open pull request fails the same check:

      .evergreen/github_app/apply-labels.mjs
        99:1  error  The value assigned to 'resp' is not used in subsequent statements  no-useless-assignment
      
      .evergreen/github_app/assign-reviewer.mjs
        84:1  error  The value assigned to 'resp' is not used in subsequent statements  no-useless-assignment
      
      ✖ 2 problems (2 errors, 0 warnings)
      

      All linting should be consolidated into a single required status check on master, so broken lint cannot merge.

      Motivation

      Who is the affected end user?

      Every contributor and maintainer of this repository, and the driver teams whose CI consumes it.

      How does this affect the end user?

      Contributors see a failing eslint check unrelated to their change on every open pull request. Maintainers can merge with lint broken, so the repo's own rule — run make lint before opening a PR — is not actually enforced.

      How likely is it that this problem or use case will occur?

      Whenever a lint-affecting dependency bump merges without someone noticing a red check, as happened with #904.

      If the problem does occur, what are the consequences and how severe are they?

      master stays red and every open pull request fails its checks until someone notices and repairs it. Moderate: CI tooling only, no product impact, but it persists until manually fixed.

      Is this issue urgent?

      Yes — every pull request is failing eslint today.

      Is this ticket required by a downstream team?

      No.

      Is this ticket only for tests?

      It is CI/tooling only; no functional behavior changes.

      Acceptance Criteria

      • Lint is a single required status check on master; a red result blocks merge.
      • The check is green on master and on open pull requests.
      • AGENTS.md accurately describes what CI runs.

            Assignee:
            Steve Silvester
            Reporter:
            Steve Silvester
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: