Uploaded image for project: 'Drivers'
  1. Drivers
  2. DRIVERS-480

Spec tests should use the same format for bulk writes

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • None
    • None
    • None
    • $i18n.getText("admin.common.words.hide")
      Key Status/Resolution FixVersion
      NODE-1457 Done
      SCALA-403 Done
      PYTHON-1546 Fixed 3.7
      CSHARP-2258 Fixed 2.10.0
      PERL-890 Fixed 2.0.0
      RUBY-1334 Fixed 2.11.0.rc0
      JAVA-2849 Fixed
      CXX-1573 Fixed 3.4.0
      PHPC-1182 Works as Designed
      MOTOR-219 Fixed 2.0
      GODRIVER-404 Done
      CDRIVER-2639 Fixed 1.10.0
      $i18n.getText("admin.common.words.show")
      #scriptField, #scriptField *{ border: 1px solid black; } #scriptField{ border-collapse: collapse; } #scriptField td { text-align: center; /* Center-align text in table cells */ } #scriptField td.key { text-align: left; /* Left-align text in the Key column */ } #scriptField a { text-decoration: none; /* Remove underlines from links */ border: none; /* Remove border from links */ } /* Add green background color to cells with FixVersion */ #scriptField td.hasFixVersion { background-color: #00FF00; /* Green color code */ } /* Center-align the first row headers */ #scriptField th { text-align: center; } Key Status/Resolution FixVersion NODE-1457 Done SCALA-403 Done PYTHON-1546 Fixed 3.7 CSHARP-2258 Fixed 2.10.0 PERL-890 Fixed 2.0.0 RUBY-1334 Fixed 2.11.0.rc0 JAVA-2849 Fixed CXX-1573 Fixed 3.4.0 PHPC-1182 Works as Designed MOTOR-219 Fixed 2.0 GODRIVER-404 Done CDRIVER-2639 Fixed 1.10.0

    Description

      There are three changes, the first two are breaking.

      The two breaking changes are in three command-monitoring tests: "bulkWrite.yml", "unacknowledgedBulkWrite.yml" and "insertMany.yml":

      https://github.com/mongodb/specifications/commit/bebf9b688f64afdec46a860f102bad0841b04c02

      The format of the "requests" array and "ordered" option changes from this:

          operation:
            name: "bulkWrite"
            arguments:
              requests:
                - insertOne: 
                    document: { _id: 4, x: 44 }
              ordered: false
      

      To this:

          operation:
            name: "bulkWrite"
            arguments:
              requests:
                - name: "insertOne"
                  arguments:
                    document: { _id: 4, x: 44 }
              options:
                ordered: false
      

      This brings Command Monitoring tests in line with the Retryable Writes and forthcoming Transactions tests.

      The non-breaking change is in the Retryable Writes tests:

      https://github.com/mongodb/specifications/commit/c0ce96daac5661f2603bfa52c9b3f683c176a292

      Before, the tests said in prose that all MongoClients should be created with retryWrites=true. Now, the tests include the following YAML:

              clientOptions:
                  retryWrites: true
      

      The clientOptions are the same for all Retryable Writes tests. Interpreting this field now will prepare you for the Transactions tests, which make real use of the field.

      Attachments

        Activity

          People

            Unassigned Unassigned
            jesse@mongodb.com A. Jesse Jiryu Davis
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: