Uploaded image for project: 'Go Driver'
  1. Go Driver
  2. GODRIVER-1034

Remove code duplication from description.NewServer and IsMaster.Result

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0
    • Component/s: Core API
    • Security Level: Public
    • Labels:
      None

      Description

      The description.NewServer function currently takes a result.IsMaster, but that adds an extra step of decoding indirection. Instead, take the code from operation.Result and use it to update the description.NewServer method.

      The description.NewServer function is only being used in the SDAM spec tests and operation.IsMaster.Result duplicates the code to create a new server description. We should change this so IsMaster.Result uses this function and remove the duplication.

       

        Attachments

          Activity

            People

            Assignee:
            isabella.siu Isabella Siu
            Reporter:
            kris.brandow Kristofer Brandow (Inactive)
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: