Uploaded image for project: 'Go Driver'
  1. Go Driver
  2. GODRIVER-1226

localThresholdMS does not default to 15 ms

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: 1.0.4
    • Fix Version/s: 1.1.0
    • Component/s: CRUD
    • Labels:
      None
    • Backwards Compatibility:
      Minor Change

      Description

      There's a defaultLocalThreshold constant defined (to 15 ms) but it's completely unreferenced. It seems like the intention was to make Client.localThreshold default to defaultLocalThreshold, possibly in newClient.

      Confusingly, there is one usage of description.LatencySelector(15 * time.Millisecond), in Operation.selectServer, but my read of that code is that it would almost never come into play, since a selector will almost always be specified. Either way, it seems like that should use defaultLocalThreshold, rather than hardcoding 15 * time.Millisecond.

      I suspect all of this means that localThresholdMS ends up defaulting to 0 ms.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: