TLS ServerName should not set if it's provided in a custom config

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Fixed
    • Priority: Major - P3
    • 1.4.1
    • Affects Version/s: None
    • Component/s: None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      When creating new connections with TLS, we set the tls.Config.ServerName field to the server's address. This is done to ensure that hostname verification and SNI both work. If a user provides a custom TLS config with a non-empty ServerName field, we should not override it. As part of this, we should add documentation to the ClientOptions.SetTLSConfig function to explain this behavior.

            Assignee:
            Divjot Arora (Inactive)
            Reporter:
            Divjot Arora (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: