Uploaded image for project: 'Go Driver'
  1. Go Driver
  2. GODRIVER-1710

TLS ServerName should not set if it's provided in a custom config

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.1
    • Component/s: None
    • Security Level: Public
    • Labels:
      None

      Description

      When creating new connections with TLS, we set the tls.Config.ServerName field to the server's address. This is done to ensure that hostname verification and SNI both work. If a user provides a custom TLS config with a non-empty ServerName field, we should not override it. As part of this, we should add documentation to the ClientOptions.SetTLSConfig function to explain this behavior.

        Attachments

          Activity

            People

            Assignee:
            divjot.arora Divjot Arora
            Reporter:
            divjot.arora Divjot Arora
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: