Uploaded image for project: 'Go Driver'
  1. Go Driver
  2. GODRIVER-1728

Send lower batchSize on getMore commands to unskip batchSize key in command monitoring tests

    XMLWordPrintableJSON

Details

    • Icon: Task Task
    • Resolution: Won't Fix
    • Icon: Major - P3 Major - P3
    • None
    • None
    • None

    Description

      3.2+ servers support the find command and the limit option so the server will only return as many documents as needed to reach the limit even if the driver sends a higher batch size. However, per https://github.com/mongodb/specifications/blob/master/source/find_getmore_killcursors_commands.rst#behavior-of-limit-skip-and-batchsize, drivers should still set a lower batchSize on getMore commands if a full batch isn't required to reach the user-specified limit. Doing so should have no behavioral changes and will allow us to unskip the batchSize key in command monitoring test assertions because this behavior is tested by this command monitoring spec test: https://github.com/mongodb/specifications/blob/90d96dabac9c645f922f2fcad1940c5c9a83e2b7/source/command-monitoring/tests/find.json#L416.

      Attachments

        Activity

          People

            Unassigned Unassigned
            divjot.arora@mongodb.com Divjot Arora (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: