Uploaded image for project: 'Go Driver'
  1. Go Driver
  2. GODRIVER-2686

Simplify "readconcern" API

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Unknown Unknown
    • 1.12.0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Not Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?

      The readconcern package unnecessarily uses the "functional options" pattern which is not used on any other public API. We should remove the functional options pattern and just export all fields in the ReadConcern struct so users can set them directly.

      Also, some exported values or functions do not need to be exported:

      • ReadConcern.MarshalBSONValue - There is no known use case for this outside of the Go driver.

      Definition of done:

      • Export all fields in the ReadConcern struct.
      • Deprecate the ReadConcern.GetLevel getter.
      • Deprecate Option type and all Option functions.
      • Deprecate WriteConcern.MarshalBSONValue

      Note that all deprecated code will be removed or unexported in Go Driver 2.0.

            Assignee:
            matt.dale@mongodb.com Matt Dale
            Reporter:
            matt.dale@mongodb.com Matt Dale
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: