Uploaded image for project: 'Go Driver'
  1. Go Driver
  2. GODRIVER-2824

Remove non-int64 Exported Connection IDs

XMLWordPrintableJSON

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Unknown Unknown
    • 2.0.0
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None
    • Major Change
    • Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      Any documentation reference to the following two fields:

      CommandStartedEvent. ServerConnectionID64
CommandFinishedEvent. ServerConnectionID64

      Should be replaced with 

      CommandStartedEvent. ServerConnectionID
CommandFinishedEvent. ServerConnectionID

      Any reference to PoolEvent.ConnectionID as uint64 should be updated to reference as int64.

      2. Would you like the user to see examples of the syntax and/or executable code and its output?

      No that is not necessary, but any existing examples that illustrate the old logic must be updated.

      3. Which versions of the driver/connector does this apply to?
      v2

      Show
      1. What would you like to communicate to the user about this feature? Any documentation reference to the following two fields: CommandStartedEvent. ServerConnectionID64 CommandFinishedEvent. ServerConnectionID64 Should be replaced with CommandStartedEvent. ServerConnectionID CommandFinishedEvent. ServerConnectionID Any reference to PoolEvent.ConnectionID as uint64 should be updated to reference as int64. 2. Would you like the user to see examples of the syntax and/or executable code and its output? No that is not necessary, but any existing examples that illustrate the old logic must be updated. 3. Which versions of the driver/connector does this apply to? v2

      GODRIVER-2737 changes the connection ID types on events to int64. To avoid breaking changes in the 1.x driver, we deprecate the old ServerConnectionID fields in favor of ServerConnectionID64. In the 2.0 version, these deprecated fields should be removed:

      • CommandStartedEvent.ServerConnectionID
      • CommandFinishedEvent.ServerConnectionID

      In the case of PoolEvent.ConnectionID, the type needs to be updated to int64 to align with the specification here. This will also require updating the poolID pipeline from connection to operation, each member of the pipeline should be labeled with TODO(GODRIVER-2824).

      Definition of done:

      • Change PoolEvent.ConnectionID to an int64.
      • Remove the deprecated ServerConnectionID fields from CommandStartedEvent and CommandFinishedEvent.
      • Update the internal representation of the connection pool's connection ID to int64 (from uint64).

            Assignee:
            preston.vasquez@mongodb.com Preston Vasquez
            Reporter:
            preston.vasquez@mongodb.com Preston Vasquez
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: