Uploaded image for project: 'Go Driver'
  1. Go Driver
  2. GODRIVER-2837

Prevent Makefile targets from swallowing errors

XMLWordPrintableJSON

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Unknown Unknown
    • 1.12.0
    • Affects Version/s: None
    • Component/s: None
    • Not Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?

      A recent release that failed to build on customers' workstations highlighted cases where the Makefile targets can silently swallow errors (see GODRIVER-2831). The main culprit is for loops in Makefiles, which only return the error code of the last evaluated statement in the loop. While we investigate better build systems, fix the issue in the short term by never using for loops in the Makefile.

      Definition of done:

      • The Makefile does not use for loops.
      • Backport safe Makefile to release/1.11 branch.

            Assignee:
            matt.dale@mongodb.com Matt Dale
            Reporter:
            matt.dale@mongodb.com Matt Dale
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: