-
Type:
Task
-
Resolution: Unresolved
-
Priority:
Minor - P4
-
None
-
Affects Version/s: None
-
Component/s: Testing
-
None
-
None
-
Go Drivers
-
None
-
None
-
None
-
None
-
None
-
None
Context
CodeQL issue:
Build commands and other items were initially added to the Taskfile build target and CodeQL worked. But there was never a set task to investigate what build command are required for the codeql analysis. Currently it follows the manual build which runs a normal go build, build with tags (not currently being passed in), and runs the compilation check for the MVS (currently 1.19). It is suspected that the compilation check is not required as the new test runs containerized and CodeQL wraps the build and binary and that doesn't occur when the build occurs within a container. It was discussed that auto build from CodeQL did not work and that build instructions were required for this.
Taskfile issue:
There are targets set up in the Taskfile to reduce duplication of the same tasks over different tasks and CI runs like codeql and evergreen. Specifically the issue we found was that codeql.yml was failing when calling Taskfile targets but when we moved the commands from the Taskfile target it worked fine so there is some strange issue where calling Taskfile targets causes a failure.
GODRIVER-3573 removed an old compile check test and used a new container based compile test. When replacing `build-compile-check` in this `build` task in the Taskfile CodeQL was failing stating it could not find a build to analyze. As a fix the steps in the `build` task in the Taskfile were manually placed in the Build step in codeql.yml.
Definition of done
- Investigate and determine what is causing CodeQL to fail to recognize the build when running compile checks in containers
- Depending on the result of the investigation if it's possible to fix the Taskfile correct it and use it in the codeql.yml
- Update the target/build commands to only include what is needed for a CodeQL Analysis.