-
Type:
Task
-
Resolution: Duplicate
-
Priority:
Unknown
-
None
-
Affects Version/s: None
-
Component/s: None
-
None
-
None
-
None
-
None
-
None
-
None
-
None
RafaelCenzano has created PR #2274: GODRIVER-3707: Consolidate duplicate binary utility functions from bsoncore and wiremessage packages in mongo-go-driver
Issue Text:
GODRIVER-3707(https://jira.mongodb.org/browse/GODRIVER-3707)
-
- Summary
- Moved and improved append functions for 32 and 64 signed and unsigned integers into bytes into binaryutils package
- Moved read function for 32 and 64 signed and unsigned integers into binaryutils package
- Moved and consolidated read c string function into binaryutils package
-
- Background & Motivation
There was duplicate code across the bsoncore and wiremessage packages. This PR consolidates it and made some minor improvements including better/safer appending thanks to work from @prestonvasquez and instead of stating read c string functions must be synced, use the same core logic and wrap a cast on the response from the bytes version for the string version.
- duplicates
-
GODRIVER-3707 Consolidate duplicate binary utility functions from bsoncore and wiremessage packages
-
- Closed
-