Context
We have had repeated cases where a PR merged green but still caused a post-merge build failure on master.
Recent examples:
- PR #2518 was created to fix unused imports introduced by PR #2501. The PR description explicitly says it fixes unused imports caused by #2501.
GODRIVER-4066documents that PR #2515 caused a build failure despite being green at merge.- PR #2527 fixed another unused-import build failure in mongo/search_index_view.go.
Definition of done
Add branch protection or repo merge rules for mongo-go-driver so PRs cannot be merged unless required CI checks are passing compared to the latest commit on the upstream. That is, "Update branch" should not be optional.
Consider using merge queues: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue
Pitfalls
Not investigated