Uploaded image for project: 'Go Driver'
  1. Go Driver
  2. GODRIVER-526

Fix command monitoring assertions in tests

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 1.5.0
    • Affects Version/s: None
    • Component/s: CRUD
    • Labels:
      None

      The command monitoring event checking code in our spec test runners skips over the "ordered", "cursor", and "batchSize" keys (https://github.com/mongodb/mongo-go-driver/blob/1c6ce243313adea74223d6f14539f18d938b5aa1/mongo/integration/cmd_monitoring_helpers_test.go#L265). We should go through these keys and see if we can change the code for the relevant CRUD functions that would not cause behavioral changes but would allow us to un-skip these keys.

      EDIT: There were some code changes required to unskip these keys:

      1. The InsertOne/InsertMany, UpdateOne/UpdateMany, ReplaceOne, and DeleteOne/DeleteMany helpers now send an explicit ordered:true field in their command. This should have no behavioral changes.
      2. A BatchSize option was added for the ListCollections helper.

            Assignee:
            divjot.arora@mongodb.com Divjot Arora (Inactive)
            Reporter:
            roland.fong Roland Fong
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: