Java Driver
  1. Java Driver
  2. JAVA-239

make sure src/main/org/bson has no mongodb deps

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major - P3 Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5
    • Component/s: None
    • Labels:
      None
    • # Replies:
      5
    • Last comment by Customer:
      true

      Activity

      Hide
      Eliot Horowitz
      added a comment -
      Show
      Eliot Horowitz
      added a comment - See some discussion here: https://github.com/mongodb/mongo-java-driver/pull/21
      Hide
      auto
      added a comment -

      Author:

      {u'login': u'agirbal', u'name': u'agirbal', u'email': u'antoine@10gen.com'}

      Message: JAVA-239: make sure src/main/org/bson has no mongodb deps
      https://github.com/mongodb/mongo-java-driver/commit/d41050612c9285e34badcc4b7551fffd2c89eb06

      Show
      auto
      added a comment - Author: {u'login': u'agirbal', u'name': u'agirbal', u'email': u'antoine@10gen.com'} Message: JAVA-239 : make sure src/main/org/bson has no mongodb deps https://github.com/mongodb/mongo-java-driver/commit/d41050612c9285e34badcc4b7551fffd2c89eb06
      Hide
      auto
      added a comment -

      Author:

      {u'login': u'agirbal', u'name': u'agirbal', u'email': u'antoine@10gen.com'}

      Message: JAVA-239: make sure src/main/org/bson has no mongodb deps
      https://github.com/mongodb/mongo-java-driver/commit/a4b72b5f49743296e42ce62e126ab6dca9fb616b

      Show
      auto
      added a comment - Author: {u'login': u'agirbal', u'name': u'agirbal', u'email': u'antoine@10gen.com'} Message: JAVA-239 : make sure src/main/org/bson has no mongodb deps https://github.com/mongodb/mongo-java-driver/commit/a4b72b5f49743296e42ce62e126ab6dca9fb616b
      Hide
      auto
      added a comment -

      Author:

      {u'login': u'agirbal', u'name': u'agirbal', u'email': u'antoine@10gen.com'}

      Message: JAVA-239: getting late, forgot to remove import lines
      https://github.com/mongodb/mongo-java-driver/commit/b1dd893165dbf97d8b146b3fe98bacbf75cc194a

      Show
      auto
      added a comment - Author: {u'login': u'agirbal', u'name': u'agirbal', u'email': u'antoine@10gen.com'} Message: JAVA-239 : getting late, forgot to remove import lines https://github.com/mongodb/mongo-java-driver/commit/b1dd893165dbf97d8b146b3fe98bacbf75cc194a
      Hide
      Antoine Girbal
      added a comment -

      in src/main: StringRangeSet was in mongodb pkg but only used from bson.
      Moved it to bson pkg.

      in src/test: 2 bson test files used TestCase from mongodb.
      Assuming we created our own TestCase to control the db before/after tests.
      I switched the bson tests to inherit testng.Assert directly.
      Ran "ant test" and made sure these tests get run.

      Following return nothing
      $ git grep import | grep mongodb | cut -d ":" -f1 | grep bson

      Show
      Antoine Girbal
      added a comment - in src/main: StringRangeSet was in mongodb pkg but only used from bson. Moved it to bson pkg. in src/test: 2 bson test files used TestCase from mongodb. Assuming we created our own TestCase to control the db before/after tests. I switched the bson tests to inherit testng.Assert directly. Ran "ant test" and made sure these tests get run. Following return nothing $ git grep import | grep mongodb | cut -d ":" -f1 | grep bson

        People

        • Votes:
          2 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:
            Days since reply:
            3 years, 8 weeks, 1 day ago
            Date of 1st Reply: