Uploaded image for project: 'Libmongocrypt'
  1. Libmongocrypt
  2. MONGOCRYPT-342

Make kms_request_t a union

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor - P4 Minor - P4
    • None
    • None
    • None

    Description

      Background & Motivation

      The kms_request_t struct has fields only applicable to certain KMS providers. The AWS specific fields are noted with comments, and the KMIP specific fields are in a separate "kmip" struct field.

      Scope

      • Address the TODO comment in the definition of the struct _kms_request_t to make a union field for provider specific data.
      • Add checks to kms_request_* functions to return an error if the input kms_request_t is set to an unexpected kms_request_provider_t.

      Attachments

        Activity

          People

            Unassigned Unassigned
            kevin.albertson@mongodb.com Kevin Albertson
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: