Details
-
Improvement
-
Resolution: Unresolved
-
Minor - P4
-
None
-
None
-
None
Description
Background & Motivation
kms_response_parser_t represents a KMS provider generic response parser. It applies to providers that use HTTP (AWS, Azure, and GCP) as well as KMIP. The KMIP parser is separated into an internal kms_kmip_response_parser_t. However, the HTTP parsing logic is still within the functions of kms_response_parser_t. Separating the HTTP parsing logic would help with code readability.
Scope
Move the HTTP parsing code into a separate kms_http_response_parser_t to have a better separation of parsing logic. And have functions like kms_response_parser_feed delegate to kms_http_response_parser_feed or kms_kmip_response_parser_feed depending on the parser type.