Uploaded image for project: 'Libmongocrypt'
  1. Libmongocrypt
  2. MONGOCRYPT-388

Segregate src and test files currently in src/mlib

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Unknown Unknown
    • None
    • Affects Version/s: 1.3.1
    • Component/s: None

      While reviewing the diff between 1.3.0 and 1.3.1 for PHPC-2031, I came across the new src/mlib/ directory that was introduced in mongodb/libmongocrypt#243 (no related JIRA ticket that I could find).

      This directory contains a mix of headers and source files, although the source files appear to just be for tests. This seems inconsistent with how code/tests are organized elsewhere in libmongoc and libmongocrypt, so I wanted to open this ticket to propose it be reorganized.

      As this pertains to PHPC, this is relevant because we manually track source files and include paths for our bundled libmongoc and libmongocrypt submodules. I originally added src/mlib as a source path but later realized the path.test.c and src.test.c files have no relevance to actually using the library (and should be excluded). This isn't problematic for the time being, but if non-test source files were to be added to this directory down the line it would definitely complicate our build and packaging scripts.

            Assignee:
            Unassigned Unassigned
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: