Uploaded image for project: 'Libmongocrypt'
  1. Libmongocrypt
  2. MONGOCRYPT-412

Support alpha tags in GetVersion.cmake

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Unknown Unknown
    • 1.4.0
    • Affects Version/s: None
    • Component/s: None

      Background & Motivation
      The publish-packages tasks have started failing on commits after the 1.4.0-alpha0 tagged release.

      Here is an example failure

      With logs:

      [2022/03/13 18:26:21.607] ./curator repo --config etc/repo_config.yaml --distro debian92 --edition org --version $pkg_version --arch x86_64 --packages repo+ ./curator repo --config etc/repo_config.yaml --distro debian92 --edition org --version 1.4.0alpha0+20220313gita088ed891d --arch x86_64 --packages repo
      [2022/03/13 18:26:21.626] [curator] 2022/03/13 18:26:21 [p=info]: curator version: e0b5f66fc89ec0acddcd40ea5f447a8300ded2b9
      [2022/03/13 18:26:21.627] [curator] 2022/03/13 18:26:21 [p=emergency]: problem constructing task for building repository: creating initial version: error parsing '1.4.0alpha0+20220313gita088ed891d': Invalid character(s) found in patch number "0alpha0"
      [2022/03/13 18:26:21.629] Command failed: command encountered problem: error waiting on process '411a7e9f-ac20-4a01-9ce2-9407a1bd5d11': exit status 1
      

      This appears to be caused by the GetVersion.cmake script not including the dash. For example, if checked out to a088ed891d89381c9b1427344dca13616f9884f3, GetVersion.cmake reports the following:

      $ cmake -P ./cmake/GetVersion.cmake
      1.4.0alpha0+20220316gita088ed891d
      

      Scope

      • Update GetVersion.cmake to match "alpha" as a prerelease part.
      • Update release instructions to note that valid prereleases can only have "alpha", "beta", or "rc" as a prerelease part.

            Assignee:
            kevin.albertson@mongodb.com Kevin Albertson
            Reporter:
            kevin.albertson@mongodb.com Kevin Albertson
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: