Uploaded image for project: 'Mongoid'
  1. Mongoid
  2. MONGOID-1825

Little refactoring of BSON::ObjectId.convert

    • Type: Icon: Task Task
    • Resolution: Done
    • 12_01_17
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None

      I don't know if you think this refactoring is good enough or not. But it's just a start.

      The BSON::ObjectId.convert method can take a lot of type in params. I extract all of type managed by this method in several method. With this refactoring, the code is a little cleaner.

      I add documentation about the third args reject_blank pass on this method. There are no documentation before.

            Assignee:
            Unassigned Unassigned
            Reporter:
            shingara Cyril Mougel
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: