Uploaded image for project: 'Mongoid'
  1. Mongoid
  2. MONGOID-1880

keeping recursion simple keeps it correct

    • Type: Icon: Task Task
    • Resolution: Done
    • 12_01_17
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None

      i've been able to trigger StackDepthErrors with significantly sized documents which make use of embedded callbacks. see

      http://s3.amazonaws.com/drawohara.com.downloads/fail.tgz

      for an example. it's very hard to tigger, so sorry for example size. (see a.rb)

      this commit passes all tests and fixes the issue above. in summary there simply don't need to be two recursive tree walks: cascadable_children already recurses so we just don't need run_cascading_callbacks

            Assignee:
            Unassigned Unassigned
            Reporter:
            ahoward ara.t.howard
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: