Uploaded image for project: 'Mongoid'
  1. Mongoid
  2. MONGOID-5263

Remove separate test run for I18n fallbacks

    • Type: Icon: Improvement Improvement
    • Resolution: Won't Do
    • Priority: Icon: Unknown Unknown
    • None
    • Affects Version/s: None
    • Component/s: None
    • None

      Currently, there is a special test run in Evergreen for "I18n fallbacks enabled". It appears that the original authors did this because I18n fallbacks is a global setting. It would be much better to handle this setting using RSpec mocks instead, and unify the test runs.Currently, there is a special test run in Evergreen for "I18n fallbacks enabled". It appears that the original authors did this because I18n fallbacks is a global setting. It would be much better to handle this setting using RSpec mocks instead, and unify the test runs.

      I would suggest the following approach:

      • Write a test helper that mocks I18n fallbacks being enabled. This can be done as an `around` block in the test suite (enable, yield, disable).
      • Search the test code for "I18n", "localized", etc. to make a list of where localization features are used.
      • For each feature, add a `content 'when I18n fallbacks enabled'` block.
      • Remove the I18n fallbacks test run.

            Assignee:
            Unassigned Unassigned
            Reporter:
            shields@tablecheck.com Johnny Shields
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: