Uploaded image for project: 'MongoDB Shell'
  1. MongoDB Shell
  2. MONGOSH-1312

Resolve coverage check failures

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 1.10.4
    • Affects Version/s: None
    • Component/s: None
    • Labels:
    • 3
    • Not Needed
    • Iteration Gargoyleosaurus, Iteration Iguanodon

      https://spruce.mongodb.com/task-history/mongosh/check_coverage seems to fail with ERROR: Coverage for lines (85.02%) does not meet global threshold (95%) on a PR with no changes.

      Since the check always fails, we may not notice if the coverage gets even lower than the current 85%, and we need to merge PRs when they are still red.

      Assuming that the coverage is calculated correctly, this ticket is about investigating a solution to get to a green state for the coverage check, few options discussed:

      • Just raising the coverage back up to 95% if low-effort / possible in one go
      • Setting the coverage threshold to 85% and opening one or more follow-up tickets to raise the coverage up to the desired amount

            leroux.bodenstein@mongodb.com Le Roux Bodenstein
            maurizio.casimirri@mongodb.com Maurizio Casimirri
            0 Vote for this issue
            2 Start watching this issue