Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-3345

Improve Transaction types tests

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Unknown Unknown
    • None
    • Affects Version/s: None
    • Component/s: Testing

      Description

      The transaction typescript tests are currently written like a block of example code that implicitly checks a number of typescript types simply by passing compilation. We should increase confidence and strictness in these tests by converting them to be an explicit set of expectations. This also make clear what we have coverage on.

      Dependencies

      • Our tsd tests in test/types (community/transaction.test-d.ts)

      Unknowns

      • Is there anything that we can't capture in an expectation? (Unlikely, but possibly)

      Acceptance Criteria

      Implementation Requirements
      • Converted test to use tsd assertions exclusively
      • Pass the type_check.test.js test
      Documentation Requirements
      • n/a
        Follow Up Requirements
      • The implementer of this refactor may come across missing coverage, depending on how much please file separate tickets to add coverage.

            Assignee:
            Unassigned Unassigned
            Reporter:
            neal.beeken@mongodb.com Neal Beeken
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: