Improve community client types tests

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Unresolved
    • Priority: Unknown
    • None
    • Affects Version/s: None
    • Component/s: Testing
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Description

      The client typescript tests are currently a mix of example code with mostly implicit checks of typescript types relying on passing compilation. We should increase confidence and strictness in these tests by converting them to be an explicit set of expectations. This also make clear what we have coverage on.

      Dependencies

      • Our tsd tests in test/types (community/client.test-d.ts)

      Unknowns

      • Is there any thing that we can't capture in an expectation? (Unlikely, but possibly)

      Acceptance Criteria

      Implementation Requirements
      • Converted test to use tsd assertions exclusively
      • Pass the type_check.test.js test
      Documentation Requirements
      • n/a
        Follow Up Requirements
      • The implementer of this refactor may come across missing coverage, depending on how much please file separate tickets to add coverage.

            Assignee:
            Unassigned
            Reporter:
            Daria Pardue
            None
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: