Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-3387

Backport findOneAndReplace fix to unified runner in 3.7

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Minor - P4 Minor - P4
    • 3.7.0
    • Affects Version/s: None
    • Component/s: None
    • Labels:
    • 1
    • Not Needed

      Use Case

      The unified runner has a mistake in the findOneAndReplace operation.
      Currently:
      return collection.findOneAndReplace(filter, replacement, translateOptions(opts));
      Should be:
      return (await collection.findOneAndReplace(filter, replacement, translateOptions(opts))).value;

      It's fixed in 4.0 as a part of NODE-3094

      Dependencies

      • Unified test runner

      Unknowns

      • none

      Acceptance Criteria

      Implementation Requirements
      • Make the stated change, it is discovered as part of the dots and dollars spec, which we aren't backporting.
      • Should we write a simple unified CRUD test to cover this path?
      Documentation Requirements
      • None
      Follow Up Requirements
      • None

            Assignee:
            neal.beeken@mongodb.com Neal Beeken
            Reporter:
            neal.beeken@mongodb.com Neal Beeken
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: