Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-3793

Rename SlaveOK to SecondaryOk throughout the codebase

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Unknown Unknown
    • 4.3.0
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None
    • Not Needed

      Use Case

      As a developer
      I want the code base to not contain the offensive term "slave"
      So that I don't become offended or distracted while working with the Node driver code

      User Impact

      Unknown

      Dependencies

      • NODE-3788 - Some of the error codes contain slaveOK in them. Completing that task first will simplify this effort.

      Unknowns

      • In db.ts --> can I rename `get slaveOk()` to `get secondaryOk()` or is this a public facing thing that needs to be deprecated? (How do I know what can be changed and what needs to be deprecated?)
      • For related NODE-3268: Is this handled in connection.ts on line 87? I see readPreference on line 91 directly below slaveOk. Should I deprecate slaveOk on line 89? I think the other references to slaveOk() can be replaced with secondaryOK() in this file.

      Acceptance Criteria

      • All references to slaveOk have been removed, renamed, or moved to a constant in both src and test files.
      • Any associated documentation that is automatically generated from code comments is also updated to reflect the non-offensive names
      • Note: spec tests with slaveOk are being covered by NODE-3791

      Implementation Requirements

      • None

      Testing Requirements

      • None

      Documentation Requirements

      • None

      Follow Up Requirements

      • NODE-3791 for spec tests with slaveOK
      • NODE-3818 to remove the slaveOk references that were deprecated as part of this ticket

            Assignee:
            daria.pardue@mongodb.com Daria Pardue
            Reporter:
            lauren.schaefer@mongodb.com Lauren Schaefer (Inactive)
            Daria Pardue
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: