dropCollection should return false and not throw on ns not found errors

XMLWordPrintableJSON

    • 2
    • Not Needed
    • 🔵 Done
    • Hide

      Create a copy of the Kickoff Template with the issue key (NODE-XXX) in the filename and share a link to the new doc via this field.

      Show
      Create a copy of the Kickoff Template with the issue key (NODE-XXX) in the filename and share a link to the new doc via this field.
    • Not Needed
    • None
    • None
    • None
    • None
    • None
    • None

      Use Case

      As a node driver engineer,
      I want the dropCollection method to suppress ns not found errors,
      So that the unified spec test runner can work without suppressing these errors manually.

      User Impact

      Users calling `dropCollection` will be impacted but the impact should be minimal.  Rather than throwing namespace not found errors, we will return `false`.  The current API for the dropCollection method returns a Promise<boolean>.  Consumers of this method may be checking for a truthy value indicating a successful drop if they care about it, but they could also have a catch block that handles this specific error, in which case this change would be breaking (as dropping a non-existent collection would now be indicated via the successful promise resolve with "false" instead of an error).

      Unknowns

      • Can this go out in a minor release? It's unlikely to really break anyone, but why take the chance given the change doesn't actually benefit our existing users.

      Acceptance Criteria

      • Remove the try-catch handling namespace not found errors from the unified runner.
      • Update dropCollection to return false for namespace not found errors.

      Documentation Requirements

      • n/a

            Assignee:
            Durran Jordan
            Reporter:
            Bailey Pearson
            Bailey Pearson
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: