Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-4393

Make `result` property from BulkWriteResult class non-enumerable

XMLWordPrintableJSON

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Unknown Unknown
    • 5.0.0
    • Affects Version/s: None
    • Component/s: None
    • Labels:
    • 2
    • Needed
    • Not Needed

      The BulkWriteResult class has a public property called `result` which contains the raw bulkWrite response.  The class also has getters which just reach into the `result` object to pass nested properties out.

      This causes issues with the unified test suite runner for `rewrapManyDataKey` operations because our BulkWriteResult class has extra properties (the `result` property), causing tests to fail.  We worked around this in the test runner by making the property non-enumerable before returning it from the operation handler, but this is not ideal.

      Acceptance Criteria

      • Refactor the BulkWriteResult class to make the result property private and non-enumerable.
      • Document change in the migration guide

            Assignee:
            durran.jordan@mongodb.com Durran Jordan
            Reporter:
            bailey.pearson@mongodb.com Bailey Pearson
            Bailey Pearson
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: