Spike: investigate and test command construction batchSize and limit

XMLWordPrintableJSON

    • Not Needed
    • 🔵 Done
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?
    • None
    • None
    • None
    • None
    • None
    • None

      Use Case

      As a node engineer
      I want descriptive unit tests for command construction, and or commented code
      So that I can prevent regression and understand the rules behind batchSize and limit options.

      Unknowns

      • How does getMore and find handle limit and batchSize correctly?
      • The driver takes the Math.abs of batchSize, is this preventing silent errors?
      • The find command used negative limits? Isn't that a special case for findOne?

      Acceptance Criteria

      Testing Requirements

      • Improve the unit tests for command construction, find and getMore specifically
      • Potentially reduce the type checking logic for command construction
        • ex. we don't need to see if batchSize is a number in mutliple places, we should check for nullish after it's been type checked.

            Assignee:
            Unassigned
            Reporter:
            Neal Beeken
            None
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: