Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-4424

Investigate NODE-4423 - Type Regressions in 4.8

    • Type: Icon: Task Task
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • 1
    • Not Needed

      NODE-4423 Description

      What problem are you facing?

      It's great with Type support for updates, but it comes with at least two regressions breaking a lot of our codebase. I'm omitting _id when creating the collection type (see screenshots) - as I believe was the recommendation before.

      1. _id is not allowed in neither $set or $setOnInsert. It is still allowed for queries, so I'm pretty sure it's not an error in our types.
      2. Setting sub-documents doesn't seem to be work either.

      This gives a lot of errors - especially since type errors on the queries/updates somehow breaks the entire type resolve chain (any subsequent code won't even recognise it's dealing with a promise anymore).

      What driver and relevant dependency versions are you using?

      Node.js Mongo Driver 4.8 and TypeScript 4.7.4

      Steps to reproduce?

      Set up the types as per the screenshots.

        1. Screenshot 2022-07-15 at 09.07.35.png
          17 kB
          PM Bot
        2. Screenshot 2022-07-15 at 09.06.57.png
          38 kB
          PM Bot
        3. Screenshot 2022-07-15 at 09.05.07.png
          64 kB
          PM Bot

            Assignee:
            neal.beeken@mongodb.com Neal Beeken
            Reporter:
            dbeng-pm-bot PM Bot
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: