Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-4910

js-bson: BSONTypeError is still checked for in tests

XMLWordPrintableJSON

    • Type: Icon: Build Failure Build Failure
    • Resolution: Fixed
    • Priority: Icon: Trivial - P5 Trivial - P5
    • bson-5.0.0
    • Affects Version/s: None
    • Component/s: None
    • 2
    • Not Needed
    • Not Needed

      What problem are you facing?

      in recent js-bson BSONTypeError got removed. However there are still tests using them.

      What driver and relevant dependency versions are you using?

      js-bson - most recent version in main

      Steps to reproduce?

      • run all tests
      • bigint_tests, uuid_tests, object_id_tests are just apssing 'fine'
      • however the intended check on the former BSONTypeError is not implemented. As BSON.BSONTypeError is undefined the tests are just checking if any error is thrown (aka the .to.throw(undefined) case)

       

            Assignee:
            neal.beeken@mongodb.com Neal Beeken
            Reporter:
            markus.korn@burda.com Markus Korn
            Durran Jordan
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: