Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-4462 Add support for GCP attached service accounts when using GCP KMS
  3. NODE-5066

Update typescript definitions for GCP and AWS to allow empty credentials

    • 0
    • Not Needed
    • Not Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?

      Use Case

      The expected usage for automatic credential fetching is:

          clientEncryption = new ClientEncryption(keyVaultClient, {
            keyVaultClient,
            keyVaultNamespace: 'keyvault.datakeys',
            kmsProviders: { gcp: {} }
          });
      

      The following TS compiler error is shown:

      Type '{}' is not assignable to type '{ email: string; privateKey: string | Buffer; endpoint?: string | undefined; } | { accessToken: string; } | undefined'.
      

      AC

      • Update the definitions to allow for an empty dictionary in "aws", "gcp", and "azure"
      • Leave "azure" unchanged, it should be updated in the ticket that adds support for the auto credential fetching
      • The same will need to be done in the driver, added to NODE-5050

            Assignee:
            neal.beeken@mongodb.com Neal Beeken
            Reporter:
            neal.beeken@mongodb.com Neal Beeken
            Bailey Pearson
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: