Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-5813

executeCommands does nothing if batch does not match any type

      Use Case

      As a Node.js engineer
      I want ensure we do not have an empty code path in bulkWrite's executeCommands
      So that we ensure all batches are executed

      User Impact

      • Very likely none.

      Dependencies

      • None.

      Unknowns

      • Is it possible to have a batch that does not return true for isInsertBatch/isUpdateBatch/isDeleteBatch?
        • If so, what should the driver do when it encounters that?
        • Update AC if it is expected or tolerable to have the driver perform no work

      Acceptance Criteria

      Implementation Requirements

      • Add validation to prevent unknown batches from letting executeCommands perform no operation

      Testing Requirements

      • Craft a batch that does not match the expected 3, assert the driver doesn't silently ignore that case.

      Documentation Requirements

      • TBD

      Follow Up Requirements

      • None

            Assignee:
            Unassigned Unassigned
            Reporter:
            neal.beeken@mongodb.com Neal Beeken
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: