Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-6366

Remove unnecessary Node.js option type patching

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Minor - P4 Minor - P4
    • None
    • Affects Version/s: None
    • Component/s: None
    • Not Needed

      Use Case

      As a Node.js driver engineer
      I want to reduce the amount of code that we have that can be inherited from the runtime
      So that we do not maintain something that can de-sync or otherwise be confused with community types

      User Experience

      • This is transparent to users (as long as the community types remain compatible)

      Dependencies

      • @types/node supporting options we have had to add

      Risks/Unknowns

      • What could go wrong while implementing this change? (e.g., performance, inadvertent behavioral changes in adjacent functionality, existing tech debt, etc)
        • What is the @types/node version compatibility expectations?
      • Is there an opportunity for better cross-driver alignment or testing in this area?
        • No
      • Is there an opportunity to improve existing documentation on this subject?
        • If we determine some compat expectations we should write them down

      Acceptance Criteria

      Implementation Requirements

      • Remove autoSelectFamily, autoSelectFamilyAttemptTimeout, and allowPartialTrustChain options from mongo_client.ts (assuming they are available in the community types now)
      • Scan for any similar public API type "patching" that can be cleaned up

      Testing Requirements

      • None

      Documentation Requirements

      • Node.js types compat

      Follow Up Requirements

      • None

            Assignee:
            Unassigned Unassigned
            Reporter:
            neal.beeken@mongodb.com Neal Beeken
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: