Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-6574

Remove `bindings` dependency from zstd package

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Unknown Unknown
    • zstd-2.0.0
    • Affects Version/s: None
    • Component/s: None
    • Not Needed

      Use Case

      As a JS developer,
      I want zstd not to depend on the `bindings` package,
      because "it's a really badly written, unmaintained, package, and any addon that moves away from it is a small victory for the usability of Node.js addon ecosystem as a whole" [Anna] .

      User Experience

      • None, part of zstd@2.0 work
      color: Color value is invalid

      Dependencies

      • none.

      Risks/Unknowns

      • n/a

      Acceptance Criteria

      Implementation Requirements

      • Remove the bindings dependency from zstd (package and package lock files)
      • Load the bindings from the build/Release folder.

      Testing Requirements

      • Ensure all tests pass.
      • We have no prebuilds for zstd, but verify that when installing a prebuilt binary on mongodb-client-encryption with the same changes made, we successfully load the native addon.

      Documentation Requirements

      • n/a

      Follow Up Requirements

      • n/a
      • if node behavior differs/will differ from other drivers, confirm with dbx devs what standard to aim for and what plan, if any, exists to reconcile the diverging behavior moving forward

            Assignee:
            bailey.pearson@mongodb.com Bailey Pearson
            Reporter:
            bailey.pearson@mongodb.com Bailey Pearson
            Neal Beeken
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: