Uploaded image for project: 'Node.js Driver'
  1. Node.js Driver
  2. NODE-6425 Update project dependencies
  3. NODE-6602

Fix network error re-wrapping in SOCKS and improve socket error messages

    • Type: Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 6.12.0
    • Affects Version/s: None
    • Component/s: None
    • 0
    • Not Needed
    • Not Needed

      Use Case

      This is to separate the work done in NODE-6552 into its own "fix" PR to keep src changes seperate.

      We're improving the error messages, and we're fixing the fact that the socks connection and our socket logic was wrapped in a try/catch and indiscriminately converted all/any errors to network errors, when only errors from socks should be converted as our makeSocket method already throws the correct kind.

      User Experience

      • What is the desired/expected outcome for the user once this ticket is implemented?
      • If bug: What is the number of impacted customers? How severe is the impact? Is anyone blocked or broken?

      Dependencies

      • upstream and/or downstream requirements and timelines to bear in mind

      Risks/Unknowns

      • What could go wrong while implementing this change? (e.g., performance, inadvertent behavioral changes in adjacent functionality, existing tech debt, etc)
      • Is there an opportunity for better cross-driver alignment or testing in this area?
      • Is there an opportunity to improve existing documentation on this subject?

      Acceptance Criteria

      Implementation Requirements

      • functional reqs, potential snafus to avoid, performance targets, etc

      Testing Requirements

      • unit test, spec test sync, etc

      Documentation Requirements

      • DOCSP ticket, API docs, etc

      Follow Up Requirements

      • additional tickets to file, required releases, etc
      • if node behavior differs/will differ from other drivers, confirm with dbx devs what standard to aim for and what plan, if any, exists to reconcile the diverging behavior moving forward

            Assignee:
            neal.beeken@mongodb.com Neal Beeken
            Reporter:
            neal.beeken@mongodb.com Neal Beeken
            Bailey Pearson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: