Compression tests do not enable compression

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Done
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • 2
    • Not Needed
    • None
    • Hide

      Create a copy of the Kickoff Template with the issue key (NODE-XXX) in the filename and share a link to the new doc via this field.

      Show
      Create a copy of the Kickoff Template with the issue key (NODE-XXX) in the filename and share a link to the new doc via this field.
    • Not Needed
    • None
    • None
    • None
    • None
    • None
    • None

      Use Case

      As a Node driver engineer,
      I want our compression tests to test compression,
      So that we have coverage with compression enabled.

      Compression is enabled in our test suite by:

      1. setting the COMPRESSORS environment variable to the allowed compressors
      2. adding the compressors URI option to the MONGODB_URI before running tests.

      However, TestConfiguration.newClient() does not actually configure new MongoClients for compression, so unless tests explicitly set a compressor, no compressor is used.

      User Experience

      Potentially uncaught bugs when compression is enabled.

      Dependencies

      none.

      Risks/Unknowns

      • Can we assert something for this configuration so that we can catch if tests are running without compression enabled?

      Acceptance Criteria

      Implementation Requirements

      • Update the common test setup (this.configuration.uri, this.configuration.newClient) to correctly apply the compression setting
      • Tests that don't use the common test setup are out of scope for this ticket

      Testing Requirements

      • All tests pass; if too many tests fail and it expands the scope of this ticket, confer with the team about fixing them in a follow up

      Documentation Requirements

      • N/A

      Follow Up Requirements

      • Only if there are a lot of new test failures

        There are no Sub-Tasks for this issue.

            Assignee:
            Bailey Pearson
            Reporter:
            Bailey Pearson
            Durran Jordan
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: