investigate errors in updated spec tests

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Unresolved
    • Priority: Unknown
    • None
    • Affects Version/s: None
    • Component/s: None
    • 0
    • None
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?
    • None
    • None
    • None
    • None
    • None
    • None

      Use Case

      As a... Node developer
      I want... to pick up the latest CSOT test specs and run them without errors
      So that... we are consistent with the latest test specs.

      User Experience

      • What is the desired/expected outcome for the user once this ticket is implemented?
        The expectation is that running spec tests will result in successes and fewer skipped tests.

      Currently, 2/3 of the new tests are failing with varying error messages:

      1. "error on aggregate if maxAwaitTimeMS is greater than timeoutMS"

      • "AssertionError: Operation aggregate succeeded but was not supposed to"
      • "AssertionError: expected MongoOperationTimeoutError: Timed out during socket read (2ms) { errorLabelSet: Set{} } to not be an instance of MongoOperationTimeoutError"

      2. "error on aggregate if maxAwaitTimeMS is equal to timeoutMS"

      • "AssertionError: Operation aggregate succeeded but was not supposed to"
      • "AssertionError: expected MongoOperationTimeoutError: Timed out during socket read (3ms) { errorLabelSet: Set{} } to not be an instance of MongoOperationTimeoutError"

      The third test is failing with a consistent message:

      3. "apply remaining timeoutMS if less than maxAwaitTimeMS"

      • "AssertionError: expected 100 to be at most 70"

      Risks/Unknowns

      • What could go wrong while implementing this change? (e.g., performance, inadvertent behavioral changes in adjacent functionality, existing tech debt, etc)
      • Is there an opportunity for better cross-driver alignment or testing in this area?
        This is cross-driver alignment.
      • Is there an opportunity to improve existing documentation on this subject?

      Acceptance Criteria

      Implementation Requirements

      • functional reqs, potential snafus to avoid, performance targets, etc
        All tests should pass, and all skipped tests should have good reasons or JIRA tickets.

      Testing Requirements

      • unit test, spec test sync, etc
        All tests are passing.

      Documentation Requirements

      • DOCSP ticket, API docs, etc
        None

      Follow Up Requirements

      • additional tickets to file, required releases, etc
      • if node behavior differs/will differ from other drivers, confirm with dbx devs what standard to aim for and what plan, if any, exists to reconcile the diverging behavior moving forward
        3 tests are being skipped, and for these we have a followup item: NODE-7297

            Assignee:
            Unassigned
            Reporter:
            Pavel Safronov
            None
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: