Drop use of ENABLE_WINDOWS_STATIC_RUNTIME when building libmongocrypt

XMLWordPrintableJSON

    • 2
    • 0
    • Not Needed
    • None
    • Not Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?
    • None
    • None
    • None
    • None
    • None
    • None

      libmongocrypt provided a configuration parameter, ENABLE_WINDOWS_STATIC_RUNTIME, to control the type of the MSVC runtime library. This parameter is now redundant with a parameter that is offered by CMake. Prefer instead to use that control.

      The parameter, CMAKE_MSVC_RUNTIME_LIBRARY, was added in CMake 3.15, which is the minimum CMake version required by libmongocrypt. See: https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html

      Dependencies

      • MONGOCRYPT-876 intends to remove the redundant configuration parameter.

      Risks/Unknowns

      • None

      Acceptance Criteria

      Implementation Requirements

      • The binding build should not rely on the to-be-removed ENABLE_WINDOWS_STATIC_RUNTIME parameter.

      Testing Requirements

      • None

      Documentation Requirements

      • None

      Follow Up Requirements

      • None

            Assignee:
            Colby Pike
            Reporter:
            Colby Pike
            Bailey Pearson, Sergey Zelenov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: