-
Type:
Task
-
Resolution: Duplicate
-
Priority:
Minor - P4
-
None
-
Affects Version/s: None
-
Component/s: None
-
Not Needed
-
None
-
None
-
None
-
None
-
None
-
None
-
None
Use Case
As a driver maintainer
I want spec tests to be exclusively vendored from our specifications repo
So that spec drift and spec test file generation tooling does not need to be maintained
User Experience
- In the main driver repo, SDAM 'errors' spec tests are not vendored from our specifications repo, but rather are locally generated via a python script (generate-error-tests.py) which reads driver owned templates. During version updates, this risks scope creep as developers bumping a minor compatible server version may be forced to skip/update the underlying templates which do not hook into our test skip logic (like our unified tests).
Further, it's unknown as to whether or not these tests provide any value as a spec test. If they duplicate coverage from our vendored spec tests, they should be removed. If they provide valuable coverage, they should be generated in the same way as other spec tests.
Dependencies
- Some of these tests are likely to be skipped after NODE-7547, and as such, the skip code should be removed after this task is completed
Risks/Unknowns
- Removal of these tests could reduce test coverage if it's covering gaps in our spec tests. Consider increasing coverage from the source–the specifications repo
Acceptance Criteria
Implementation Requirements
- generate-error-tests.py should be removed, alongside any templates
- if the tests stick around, our test runner should be able to skip these tests based on infra requirements, instead of failing
Testing Requirements
- N/A
Documentation Requirements
- DOCSP ticket, API docs, etc
Follow Up Requirements
- additional tickets to file, required releases, etc
- if node behavior differs/will differ from other drivers, confirm with dbx devs what standard to aim for and what plan, if any, exists to reconcile the diverging behavior moving forward