-
Type:
Sub-task
-
Resolution: Unresolved
-
Priority:
Unknown
-
None
-
Affects Version/s: None
-
Component/s: None
-
0
-
Not Needed
-
None
-
None
-
None
-
None
-
None
-
None
-
None
sourced from: https://github.com/mongodb-js/zstd/pull/126
Use Case
As a mongodb developer
I want to use v10 of eslint
So that code can continue to be maintainable
User Experience
- eslint checks should pass with the same rule parity following the v9 non-flat configuration file
Dependencies
- N/A
Risks/Unknowns
- A simple transition could cause a lack of parity with v9 rules to source code (e.g: an added rule in v10 which supplants a rule in v9, might require source code changes), this is acceptable for tests, but not for source (ie: no breaking change should need be introduced)
- Dissimilar linting between repo's
- Other plugin incompatibility discoveries
Acceptance Criteria
Implementation Requirements
- v10 of eslint requires a [flat configuration file|https://eslint.org/docs/latest/use/configure/migration-guide]]
- After this change, eslint should pass all repo linting scripts
- .eslintignore will be supplanted by ["ignores" in the new eslint config|https://eslint.org/docs/latest/use/configure/ignore]
Testing Requirements
- Compare verbose output of main eslint checks to new v10 eslint checks, ensure all files are covered
- Smoke test rule changes to ensure they are actually emitting errors/warns
Documentation Requirements
- N/A
Follow Up Requirements
Extra info:
Upgrade footprint after updating to v10:
> @mongodb-js/zstd@7.0.0 check:eslint > eslint *.ts lib/*.js test/*.js .*.json /Users/john/dev/johnmtll/mongodb-js/zstd/.mocharc.json 1:1 error Use the global form of 'use strict' strict/Users/john/dev/johnmtll/mongodb-js/zstd/.prettierrc.json 1:1 error Use the global form of 'use strict' strict/Users/john/dev/johnmtll/mongodb-js/zstd/.release-please-manifest.json 1:1 error Use the global form of 'use strict' strict/Users/john/dev/johnmtll/mongodb-js/zstd/index.d.ts 1:1 error Use the global form of 'use strict' strict/Users/john/dev/johnmtll/mongodb-js/zstd/lib/index.js 39:5 error There is no `cause` attached to the symptom error being thrown preserve-caught-error 50:5 error There is no `cause` attached to the symptom error being thrown preserve-caught-error/Users/john/dev/johnmtll/mongodb-js/zstd/test/glibc.test.js 1:1 error Use the global form of 'use strict' strict/Users/john/dev/johnmtll/mongodb-js/zstd/test/index.test.js 1:1 error Use the global form of 'use strict' strict 1:9 error 'test' is already defined as a built-in global variable no-redeclare✖ 9 problems (9 errors, 0 warnings)
- clones
-
NODE-7798 [zstd] upgrade eslint v9 -> v10
-
- Closed
-