-
Type:
Bug
-
Resolution: Unresolved
-
Priority:
Critical - P2
-
None
-
Affects Version/s: None
-
Component/s: Compressors
-
2
-
None
-
None
-
None
-
None
-
None
-
None
-
None
Use Case
As a... node developer
I want... all hello operations to be unencrypted
So that... the node driver is spec compliant and sfp does not block our monitoring calls
User Experience
- Monitoring hello calls are sent uncompressed
Dependencies
- none
Risks/Unknowns
- This matches the specification, so there should be no noticeable differences
Acceptance Criteria
Implementation Requirements
- all hello messages are uncompressed, irrespective of current compression level
Testing Requirements
- existing tests pass
- add new integration test check that verifies that hello operations are never compressed in either the monitoring or the handshake cases
Documentation Requirements
- none
Follow Up Requirements
- none
—
h4: Description
The compression spec requires that the hello command is never compressed.
However, the Node driver does not include hello in its list of uncompressed commands.
h4: Impact
Based on the requirements of the compression specification, the secure frontend processor (see this spec) rejects compressed messages on unauthenticated connections, so monitoring connections in the Node driver are being closed on the first streaming hello when compression has been negotiated.
Acceptance criteria:
- Add hello to the list
- Test that hello is not compressed when executed by the application explicitly, or by server monitors (streaming hello, non-streaming hello, RTT)
- related to
-
NODE-3960 Add missing compression spec test coverage
-
- Backlog
-