Uploaded image for project: 'PHP Driver: Extension'
  1. PHP Driver: Extension
  2. PHPC-1624

Consider 32-bit platforms when constructing UTCDateTime in tests

XMLWordPrintableJSON

    • Type: Icon: Task Task
    • Resolution: Gone away
    • Priority: Icon: Minor - P4 Minor - P4
    • None
    • Affects Version/s: None
    • Component/s: Tests
    • None
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?

      Various tests construct UTCDateTimes from 64-bit integer literals, and do so without a SKIPIF check for PHP_INT_SIZE. For compatibility with 32-bit platforms, we should change these tests to use smaller integers or numeric strings (UTCDateTime's constructor will parse strings as 64-bit numbers).

      Note: the fact that we haven't noticed failures in these tests before suggests that they may not be running on a 32-bit platform in our matrix – or they are and passing for some other unknown reason.

      More generically, we may want to repurpose this ticket to audit the test suite for any instance of numeric literals exceeding the range of 32-bit signed integers.

            Assignee:
            Unassigned Unassigned
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: