Uploaded image for project: 'PHP Driver: Extension'
  1. PHP Driver: Extension
  2. PHPC-1929

ReadConcern tests need not exhaustively test each constant

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Unknown
    • Resolution: Fixed
    • None
    • 1.15.0
    • Tests

    Description

      The ReadConcern tests (e.g. debug output, serialization) currently test all of the constants, even though ReadConcern itself is not limited to using those constants. Its constructor accepts any string as a level. These tests should be stripped down to just test a single level string. Only readconcern-constants.phpt need exhaustively test each constant value.

      This came up in mongodb/mongo-php-driver#1243 for PHPC-1761 when a new constant was being added.

      Attachments

        Issue Links

          Activity

            People

              levon.babayan@mongodb.com Levon Babayan (Inactive)
              jmikola@mongodb.com Jeremy Mikola
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: